Baraza
  • Communities
  • Create Post
  • Create Community
  • heart
    Support Lemmy
  • search
    Search
  • Login
  • Sign Up
@petsoi@discuss.tchncs.de to Linux@lemmy.ml •
edit-2
9 months ago

RustDesk: I Found This Open-Source TeamViewer Alternative Impressive!

news.itsfoss.com

external-link
message-square
22
fedilink
146
external-link

RustDesk: I Found This Open-Source TeamViewer Alternative Impressive!

news.itsfoss.com

@petsoi@discuss.tchncs.de to Linux@lemmy.ml •
edit-2
9 months ago
message-square
22
fedilink

Please have a look at the warnings in the comments:

https://discuss.tchncs.de/post/21632052/12893621

https://discuss.tchncs.de/post/21632052/12897257

  • Psyhackological
    link
    fedilink
    3•
    edit-2
    9 months ago

    Wth is that, that is the most anti-idiomatic code I have ever seen

    https://github.com/rustdesk/rustdesk/blob/master/src%2Fplatform%2Flinux.rs#L176

    pub fn get_cursor() -> ResultType<Option<u64>> {
        let mut res = None;
        DISPLAY.with(|conn| {
            if let Ok(d) = conn.try_borrow_mut() {
                if !d.is_null() {
                    unsafe {
                        let img = XFixesGetCursorImage(*d);
                        if !img.is_null() {
                            res = Some((*img).cursor_serial as u64);
                            XFree(img as _);
                        }
                    }
                }
            }
        });
        Ok(res)
    }
    

    I’m not an expert but this seems wrong.

    • @angel@sopuli.xyz
      link
      fedilink
      3•9 months ago

      Yep, I’m not a Rust expert either, but this is pretty cursed. The comments on this post have some more examples of bad rustdesk code: https://lobste.rs/s/njfvjb/rustdesk_with_tailscale_on_arch_linux

Linux@lemmy.ml

!linux@lemmy.ml

Subscribe from Remote Instance

Create a post
You are not logged in. However you can subscribe from another Fediverse account, for example Lemmy or Mastodon. To do this, paste the following into the search field of your instance: !linux@lemmy.ml

From Wikipedia, the free encyclopedia

Linux is a family of open source Unix-like operating systems based on the Linux kernel, an operating system kernel first released on September 17, 1991 by Linus Torvalds. Linux is typically packaged in a Linux distribution (or distro for short).

Distributions include the Linux kernel and supporting system software and libraries, many of which are provided by the GNU Project. Many Linux distributions use the word “Linux” in their name, but the Free Software Foundation uses the name GNU/Linux to emphasize the importance of GNU software, causing some controversy.

Rules

  • Posts must be relevant to operating systems running the Linux kernel. GNU/Linux or otherwise.
  • No misinformation
  • No NSFW content
  • No hate speech, bigotry, etc

Related Communities

  • !opensource@lemmy.ml
  • !libre_culture@lemmy.ml
  • !technology@lemmy.ml
  • !libre_hardware@lemmy.ml

Community icon by Alpár-Etele Méder, licensed under CC BY 3.0

  • 130 users / day
  • 1.03K users / week
  • 4.66K users / month
  • 10.9K users / 6 months
  • 54.3K subscribers
  • 7.57K Posts
  • 79K Comments
  • Modlog
  • mods:
  • @nooter692@lemmy.ml
  • @AgreeableLandscape@lemmy.ml
  • @MarcellusDrum@lemmy.ml
  • Arthur Besse
  • Cyclohexane
  • BE: 0.19.3
  • Modlog
  • Instances
  • Docs
  • Code
  • join-lemmy.org